Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support incremental extraction with airbyte source defined cursor fields #13

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

JichaoS
Copy link
Contributor

@JichaoS JichaoS commented Mar 7, 2024

See airbyte docs here

The airbyte discover command does not return a cursor_field for incrementally enabled extractions. It returns source_defined_cursor=true and default_cursor_field=[list_of_cursors]

See airbyte docs here 
 - https://docs.airbyte.com/understanding-airbyte/airbyte-protocol#configuredairbytestream
 - https://docs.airbyte.com/understanding-airbyte/airbyte-protocol#logic-for-resolving-the-cursor-field

The airbyte `discover` command does not return a `cursor_field` for incrementally enabled extractions. It returns `source_defined_cursor=true` and `default_cursor_field=[list_of_cursors]`
@JichaoS JichaoS changed the title Fix: support incremental extraction with airbyte source defined cursor fields fix: support incremental extraction with airbyte source defined cursor fields Mar 7, 2024
@z3z1ma
Copy link
Collaborator

z3z1ma commented Mar 7, 2024

LGTM

@z3z1ma z3z1ma merged commit dfff678 into MeltanoLabs:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants