CSV seperators & dev activity

[svenkerud]

hi @pnadolny13,

You seem to be the most active maintainer on this project so I took the liberty to ping you.
I am wondering if there is currently any dev activity on this project? most of the commits apears to be dependabot generated.

If there is dev activity I was wondering if there is anything going on with regards to adding support for other csv sepperators, spessifically ;.

Thanks in advance for your help.

[pnadolny13]

Hey @svenkerud - yep I've been the primary maintainer. Happy to review PRs or help get new features added!

I think this is a reasonable and generically useful feature to add. In

tap-csv/tap_csv/client.py

Line 84 in 3769f4e

reader = csv.reader(f)

we load the csv with csv.reader() which takes a bunch of optional arguments https://docs.python.org/3/library/csv.html#csv-fmt-params that we're not using right now. We could probably expose those to the tap config, maybe under a single csv_format object?

Is this something you'd consider contributing a PR for?

[svenkerud]

Briliant thanks for the repy.
I am happy to look into this issue as this is deffinetly something we need.
I will ping you once i have a PR ready.

[pnadolny13]

@svenkerud a PR just merged to add configurable encoding #58. I think your new setting could basically replicate that same pattern. I take back what I said about using a single csv_format key. The files config dict at the file level is probably a fine place for it to go.

[Bartman0]

I made #70 to implement the intended configuration. I needed it too, and I could not find a follow-up on this discussion

[pnadolny13]

@Bartman0 @svenkerud the PR was merged so I'm closing this issue. I will cut a new release, after I merge the dependabot PRs.