Add ability to specify encoding to help with UnicodeDecodeError errors #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnadolny13
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
@seajhawk This is awesome! 🔥
I just left a few comments related the descriptions but everything else looks great and worked for me. I appreciate you adding the test data and unit test too.
|
Great improvement! Thanks for catching that! |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use tap-csv to import files with unexpected encoding on Windows. To work around this, I have added an
encodingparameter that will allow the user to specify the encoding of their choice such as 'UTF-8', 'latin1', etc.