Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a base GraphQL stream to reduce unnecessary API calls #48

Closed
Ry-DS opened this issue Nov 14, 2021 · 0 comments · Fixed by #78
Closed

Implement a base GraphQL stream to reduce unnecessary API calls #48

Ry-DS opened this issue Nov 14, 2021 · 0 comments · Fixed by #78

Comments

@Ry-DS
Copy link
Contributor

Ry-DS commented Nov 14, 2021

Currently we have a REST base stream implemented for our tap:
https://github.com/MeltanoLabs/tap-github/blob/main/tap_github/client.py#L10

However, it would be greatly beneficial if we also considered making a base stream for the Github GraphQL API. This is because the Graphql API uses a 'credits' system which makes it a lot more adaptive at collecting granular data compared to REST where each resource, no matter how small, takes up an entire request.

Streams that can greatly benefit from the GraphQL API:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant