Initialize UserContributedToStream using Graphql #78
Conversation
ericboucher
changed the title
|
|
||
| name = "user_contributed_to" | ||
| query_path = "user.repositoriesContributedTo.nodes" | ||
| primary_keys = ["username"] |
There was a problem hiding this comment.
Is there a way to fetch the data by some other, more stable, identifier (thinking nodeId or id), as users can change their username at any time? I don't know what consequences this would have on this stream.
There was a problem hiding this comment.
sadly, I did not find any...
tap_github/user_streams.py
Outdated
| """ | ||
|
|
||
| schema = th.PropertiesList( | ||
| th.Property("id", th.StringType), |
There was a problem hiding this comment.
From what I understand, id in github's graphql context is the same as nodeId in REST. Would it be worth renaming the properties here to give a consistent naming in the output of the tap? REST has both id (an integer) and node_id (string).
Co-authored-by: Laurent Savaete <laurent@where.tf>
tap_github/client.py
Outdated
| https://docs.python-requests.org/en/latest/api/#requests.Response | ||
| """ | ||
| resp_json = response.json() | ||
| data = glom(resp_json["data"], self.query_path) |
There was a problem hiding this comment.
TIL glom 🙂
The SDK already supports JSONPath, so I'm curious what are the benefits of glom over that.
There was a problem hiding this comment.
@edgarrmondragon I am trying to use JSONPath and it works with online tools but I can't get it to work in the code.
This is what I am doing:
resp_json = response.json()
yield from extract_jsonpath(self.query_jsonpath, input=resp_json)
with query_jsonpath = "$.data.user.repositoriesContributedTo.nodes.*"
The list returns empty
There was a problem hiding this comment.
nvm I think I fixed it in 9435df7
There was a problem hiding this comment.
@ericboucher looks good!
|
Kudos, SonarCloud Quality Gate passed!
|
Initialize UserContributedToStream using Graphql
This also fixes #48