Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #209

Merged
merged 8 commits into from
Jun 14, 2023
Merged

chore: update dependencies #209

merged 8 commits into from
Jun 14, 2023

Conversation

laurentS
Copy link
Contributor

@laurentS laurentS commented May 15, 2023

This PR updates dependencies, including the sdk to 0.27.0 0.22.0.

Some are skipped as they do not support python 3.7 anymore. See #208

@laurentS laurentS requested a review from ericboucher May 15, 2023 08:17
@ericboucher
Copy link
Contributor

Tests are failing:

FAILED tap_github/tests/test_tap.py::test_last_state_message_is_valid - assert 'progress_markers' not in '{"type": "S...000Z"}}]}}}}'
  'progress_markers' is contained here:
  

@laurentS
Copy link
Contributor Author

I've changed the sdk version to v0.22.1 temporarily to confirm that tests are passing. See linked sdk issue for details on the problem this PR surfaced.

@ericboucher
Copy link
Contributor

@laurentS would you like to merge this like that or wait for a new release of the SDK?

@laurentS
Copy link
Contributor Author

I guess it's harmless to merge it as is, but there is also no emergency in the sense that I don't think the SDK upgrade 0.19 -> 0.22.1 brings any changes that this tap uses.
Let's keep this open until the sdk situation is clarified, it'll save us a bit of PR overhead :)

@kgpayne
Copy link

kgpayne commented May 17, 2023

@laurentS @ericboucher I have a PR to fix this issue in the SDK, with tests passing here (above) when pointing at the PR branch. Will revert to > 0.22.1 here for now and update you once the fix is released 🙂👍

This reverts commit f8b1143.
@JohannesRudolph
Copy link

@laurentS any idea when this will land? I'm prepping a PR to fix incremental loading of the GH Actions (workflow_runs etc.) streams at https://github.com/meshcloud/tap-github/tree/feature/fix-actions-streams and based this off of your branch here.

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@laurentS
Copy link
Contributor Author

@JohannesRudolph I'm going to merge this as is, with the sdk updated to 0.22.1, and we can open a new PR to update to the latest sdk version when meltano/sdk#1708 is merged.

@laurentS laurentS merged commit 400a068 into main Jun 14, 2023
9 checks passed
@laurentS laurentS deleted the update-dependencies branch June 14, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants