perf: Use composite api in discover #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edgarrmondragon is it worth merging this in since it might remain the default for a while longer? |
@andyoneal I'm not familiar with Salesforce APIs so I'm pinging @pnadolny13 to see if he has thoughts about it. |
|
@edgarrmondragon @pnadolny13 if meltano/meltano#8518 gets merged, it would be really nice to have this discovery speed up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the Composite REST API to batch describe calls during discover. Will describe up to 25 sObjects per call.
On my salesforce instance with just over 1000 streams, discover runs almost 2.5x faster, or in about 1m0s down from 2m23s.