Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MIDI input and ChromeOS support #27

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Conversation

code-monet
Copy link
Contributor

Tested on a Chromebook with a Casio keyboard. The npm run build command is hanging forever so I have not been able to deploy a demo instance on Netlify. Fix for #22

@MelvilQ MelvilQ merged commit 59cdef4 into MelvilQ:master Jul 16, 2022
@MelvilQ
Copy link
Owner

MelvilQ commented Jul 16, 2022

Thank you very much for the fix, I will publish it as soon as I can :)

@code-monet
Copy link
Contributor Author

Happy to help! BTW I still am seeing npm run build hang, both on my dev machine and on Netlify. I'll take a look today. Did you follow a reference or tutorial for setting up the build script? That would help!

@MelvilQ
Copy link
Owner

MelvilQ commented Jul 16, 2022

Hmm, that's weird. The build script is the default of vue.js (the project was generated using the vue-cli four years ago). On my side the netlify deploys have been successful and I was able to build the app version 1.8.1 today for release on Google Play. I just did a test on my local machine, deleted the node_modules folder and ran npm i and npm run build, it was successful.

@code-monet
Copy link
Contributor Author

Interesting, I would think that the Netflify should work for both of us in that case. Anyway, it's not too important to debug that at the moment, since you're able to build and deploy! I can continue testing using the dev action. Thanks for the quick deploy!

@MelvilQ MelvilQ mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants