Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the main window when opening a second instance #101

Merged
merged 2 commits into from
Feb 14, 2021
Merged

Open the main window when opening a second instance #101

merged 2 commits into from
Feb 14, 2021

Conversation

mkody
Copy link
Contributor

@mkody mkody commented Feb 12, 2021

Instead of throwing an error, launch the Assistant.

This way we can trigger it from the desktop or taskbar, which can be more accessible than a keyboard shortcut or double-clicking the tray icon.
Fixes #94

Instead of throwing an error, launch the Assistant.
@imreallyliam
Copy link

Just had the privilege of building this on Fedora 34, works great with Wayland!

@Melvin-Abraham Melvin-Abraham linked an issue Feb 13, 2021 that may be closed by this pull request
- When launching Dev Mode instance of the app, second instance error will be shown
- Check if window is visible before forcing window launch
@Melvin-Abraham
Copy link
Owner

@mkody Thank you for the contribution 👋. I have made a minor change wherein the second instance error will be shown when user launches an instance in Dev Mode. This is done so as to make sure the developer is testing the code on a fresh instance. For end users launching the production version of the app, this won't be shown.

@Melvin-Abraham Melvin-Abraham merged commit 8d931ed into Melvin-Abraham:master Feb 14, 2021
@mkody
Copy link
Contributor Author

mkody commented Feb 14, 2021

Thanks @Melvin-Abraham!

Just wondering if the if (!mainWindow.isVisible()) check you put should also be added when we use the tray context menu and the double-click even on the tray icon?

@mkody mkody deleted the patch-1 branch February 14, 2021 14:41
@Melvin-Abraham
Copy link
Owner

@mkody That particular check is not put there intentionally, since that option is for forcing the application to re-launch in case the app does not respond properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants