Fix problems with class variables overlapping #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-diudiun
requested changes
Jul 8, 2020
src/Router.php
Outdated
Comment on lines
18
to
23
| function __construct(array $data = []) { | ||
| $this->serviceName = $data['serviceName'] ?? null; | ||
| $this->actionName = $data['actionName'] ?? null; | ||
| $this->params = $data['params'] ?? null; | ||
| $this->routes = []; | ||
| } |
There was a problem hiding this comment.
тут видно что количество водящих не динамическое и не большое - лучше передать их все напрямую
There was a problem hiding this comment.
прям параметрами без обверти масивом
src/Router.php
Outdated
| throw new RoutingException(_("Empty routes"), 1); | ||
| } | ||
|
|
||
| $this->routes = $routes; |
There was a problem hiding this comment.
в каждом обьекте роутера будет свой набор роутов дублирующийся массив на 100+ строк на каждый паралельный реквест. то что мы говорили про статический доступ
src/Router.php
Outdated
| throw new RoutingException(_("Route not found."), 501); | ||
| } | ||
|
|
||
| return new self($routeData); |
There was a problem hiding this comment.
Передать сразу конкретные переменные
src/Router.php
Outdated
|
|
||
| $routesCount = 0; | ||
|
|
||
| foreach ($this->routes as $regExpString => $route) { |
There was a problem hiding this comment.
Юзать роуты не с обьекта
added static obj logic for specific env, made changes by pullrequest
oleksandr-diudiun
requested changes
Jul 8, 2020
src/Router.php
Outdated
| } | ||
| return self::$instance[$environment]; | ||
| } else { | ||
| die("Некорректная среда"); |
There was a problem hiding this comment.
Нельзя просто взять и умереть нельзя останавливать процесс изза одного реквеста есть же паралельные реквесты
oleksandr-diudiun
approved these changes
Jul 8, 2020
oleksandr-diudiun
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
робочий варіант з мінімумом змін в уже існуючих проектах де використовується бібліотека
протестив в одному з проектів