Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix close modal react 18 #83

Merged

Conversation

EugeneYaremenko
Copy link
Contributor

fixing build problems

@@ -4,7 +4,7 @@ const path = require('path');
const webpack = require('webpack');

const config = {
mode: process.env.NODE_ENV || 'production',
mode: process.env.NODE_ENV || 'development',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, when I up webpack v5, I got conflict problem:

WARNING in DefinePlugin Conflicting values for 'process.env.NODE_ENV',

@max-mykhailenko max-mykhailenko merged commit 6a35ce3 into Memcrab:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants