Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling image picking causes Alert "Imgur upload failed" [fixes #628] #689

Merged

Conversation

felix-staud
Copy link
Contributor

@felix-staud felix-staud commented Jul 15, 2023

when opening the image picker in a new post or a new comment and then clicking cancel the error alert no long appears

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

When opening the image picker in a new post or a new comment and then clicking cancel the error alert no long appears

Screenshots

Screen.Recording.2023-07-15.at.13.19.13.mov
Screen.Recording.2023-07-15.at.13.24.28.mov

Test Plan

New Post

  1. Open lemmy app
  2. Navigate to any community where you have a + Post Button available
  3. Press the + Post Button
  4. Click the image icon at the bottom right to open the img picker
  5. Press Cancel at the top left
  6. There should be NO alert anymore

New Comment

  1. Open lemmy app
  2. Open any Post where you can comment on
  3. Press the +Comment Button
  4. Click the image icon at the bottom right to open the img picker
  5. Press Cancel at the top left
  6. There should be NO alert anymore

fixes #628

when opening the image picker in a new post or a new comment and then clicking cancel the error alert no long appears
@felix-staud felix-staud changed the title fix #628 fix #628 - Cancelling image picking causes Alert "Imgur upload failed Jul 15, 2023
@felix-staud felix-staud changed the title fix #628 - Cancelling image picking causes Alert "Imgur upload failed fix #628 - Cancelling image picking causes Alert "Imgur upload failed" Jul 15, 2023
@felix-staud felix-staud changed the title fix #628 - Cancelling image picking causes Alert "Imgur upload failed" Cancelling image picking causes Alert "Imgur upload failed" [fixes #628] Jul 15, 2023
@gkasdorf gkasdorf merged commit 1ea9778 into Memmy-App:main Jul 16, 2023
3 checks passed
@felix-staud felix-staud deleted the feature/628-img-pick-cancel-alert branch July 16, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error If Cancelling Add Image To Comment
2 participants