Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toggle to show read posts in communities #719

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Add toggle to show read posts in communities #719

merged 7 commits into from
Jul 20, 2023

Conversation

ktgd
Copy link
Contributor

@ktgd ktgd commented Jul 17, 2023 •
edited
Loading

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

#710
Adds a toggle to show/hide read posts on Communities
Consolidated "Hide Read Posts" settings into their sub-settings screen

Screenshots


Test Plan

  1. Toggle each of the settings to verify that posts are shown/hidden correctly.

@ktgd ktgd marked this pull request as ready for review July 18, 2023 03:40
@ktgd ktgd requested review from gkasdorf and sgriff96 July 18, 2023 03:40
@ktgd ktgd changed the title WIP: Add toggle to show read posts in communities Add toggle to show read posts in communities Jul 18, 2023
@sgriff96 sgriff96 merged commit 8438773 into Memmy-App:main Jul 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgriff96 sgriff96 sgriff96 approved these changes

@gkasdorf gkasdorf Awaiting requested review from gkasdorf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ktgd @sgriff96