Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed Item Context Menu #746

Merged
merged 8 commits into from
Jul 18, 2023
Merged

Feed Item Context Menu #746

merged 8 commits into from
Jul 18, 2023

Conversation

sgriff96
Copy link
Collaborator

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

Please provide a summary of what your PR does

Screenshots

If the UI has been changed, include screenshots.
We will not review your PR without screenshots if they are applicable.

Test Plan

Please documemnt the steps required to test your PR

@sgriff96 sgriff96 linked an issue Jul 18, 2023 that may be closed by this pull request
@gkasdorf
Copy link
Collaborator

gkasdorf commented Jul 18, 2023

So all I've done is ran a flamegraph and it looks like when we upvote or downvote here we re-renender the entire feeditem. I'll look into what might cause that, but I think either converting over to context (probably best) or really nailing down composition (alternative if context proves too annoying) should clean up not just this but other issues as well.

Haven't looked at code yet so let me take a peek.

Mind you this isn't only an issue with upvoting in this way but just upvoting in general. Really shows the need to clean this up.

@sgriff96 sgriff96 changed the title Sgriff96/feed-context-menu Feed Item Context Menu Jul 18, 2023
@sgriff96 sgriff96 merged commit dbbc35f into main Jul 18, 2023
4 checks passed
@sgriff96 sgriff96 deleted the sgriff96/feed-context-menu branch July 18, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context Menu for Posts from Post Feed views
2 participants