Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT-BR Translation #765

Merged
merged 8 commits into from Jul 21, 2023
Merged

PT-BR Translation #765

merged 8 commits into from Jul 21, 2023

Conversation

chakigel
Copy link
Contributor

@chakigel chakigel commented Jul 19, 2023

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

This adds the PT-BR json file, for the translation as discussed here

Test Plan

Switch to Portuguese and check the string lengths.

src/plugins/i18n/locales/pt_br.json Outdated Show resolved Hide resolved
src/plugins/i18n/locales/pt_br.json Outdated Show resolved Hide resolved
@gkasdorf
Copy link
Collaborator

Thank you! I'll merge this in shortly.

@felix-staud
Copy link
Contributor

Thanks for your translation.
You are missing adding the language as available inside the plugins/i18n.ts file

@chakigel
Copy link
Contributor Author

Hey, thanks for letting me know.
The two typos @lacarsi mentioned have been fixed and I added the option to plugins/i18n.ts.

@gkasdorf gkasdorf merged commit c438277 into Memmy-App:main Jul 21, 2023
3 checks passed
@felix-staud
Copy link
Contributor

@gkasdorf @chakigel i think this translation wont work as right now we only use the initial language prefix pt not the full one pt_br thus the language detector will never provide the proper key for the translation to take effect

@gkasdorf
Copy link
Collaborator

gkasdorf commented Jul 21, 2023

@felix-staud Oh interesting. I'll fix that up then. Thanks.

We would probably need to do something like see if the language is available under (I'm guessing it uses en_us, en_gb, etc) language_locale then just check for language if the former doesn't exist? I'll need to check more into the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants