Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bug report button #817

Merged
merged 14 commits into from
Jul 23, 2023
Merged

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Jul 22, 2023

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • (kinda) You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

Adds a Report a Bug Button into the root Settings menu with version and device pre-filled (I've tested it by activating issues on my fork and updating my main branch temporarily)

Screenshots

ℹ️ ignore the dev settings, those are obviously not present in live

imageimage

Test Plan

  1. Go to Settings
  2. Click on Report a Bug
  3. Sends you to github with proper forwarind to new issue - bug tempalte.
  4. When the changes to the bug_report.yml are merged into main you can also notice version and device being pre-filled

add a bug report button that automatically fills the 'version' and 'device' field in the bug report form (added ids to the form accordingly)
Copy link
Collaborator

@sgriff96 sgriff96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not getting version or device populated, its leaving version as Ios 17.x beta but simulator is running 16.4, and its leaving device empty. Is that just a simulator issue?

src/components/screens/Settings/SettingsIndexScreen.tsx Outdated Show resolved Hide resolved
@flx-sta
Copy link
Contributor Author

flx-sta commented Jul 22, 2023

I'm not getting version or device populated, its leaving version as Ios 17.x beta but simulator is running 16.4, and its leaving device empty. Is that just a simulator issue?

When the changes to the bug_report.yml are merged into main you can also notice version and device being pre-filled

this will only be testable after merge unfortunately or on a fork.

Unfortunately I can't pre-fill the iOS Version select as this is a missing feature right now (cant find the issue right now :()

I could though still provide the url param anyway so that if it ever starts working it's already there.
Or we replace the field with an input

@flx-sta
Copy link
Contributor Author

flx-sta commented Jul 22, 2023

image

@flx-sta flx-sta requested a review from sgriff96 July 22, 2023 21:16
@gkasdorf
Copy link
Collaborator

The only thing I would say is maybe it should open in the default browser always? Since the user is more likely to be signed in there than in the app. Otherwise seems fine.

@flx-sta
Copy link
Contributor Author

flx-sta commented Jul 23, 2023

The only thing I would say is maybe it should open in the default browser always? Since the user is more likely to be signed in there than in the app. Otherwise seems fine.

How do I guarantee that ? Just to save some research time

@gkasdorf
Copy link
Collaborator

The only thing I would say is maybe it should open in the default browser always? Since the user is more likely to be signed in there than in the app. Otherwise seems fine.

How do I guarantee that ? Just to save some research time

Just use Linking.openURL() instead of WebBrowser and it should open in the default.

@flx-sta
Copy link
Contributor Author

flx-sta commented Jul 23, 2023

Just use Linking.openURL() instead of WebBrowser and it should open in the default.

added that. And some missing translations

@sgriff96 sgriff96 merged commit e24ddef into Memmy-App:main Jul 23, 2023
4 checks passed
@flx-sta flx-sta deleted the feature/report-a-bug-btn branch July 23, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants