fix: use undefined instead of "unspecified" for initialColorMode
#856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since undefined is supported by keyboardAppearance, ActionSheets and tint (which is where this field used today), I think this is a more sensible fallback for themes without a `initalColorMode`
|
Seems reasonable to me. |
gkasdorf
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Creator Checklist
Ensure you've checked the following before submitting your PR:
Summary
This changes the interfaces
IThemefieldinitialColorModeto acceptundefinedinstead if the string"unspecified", which caused typescript errors several places.Since
undefinedis supported bykeyboardAppearance, ActionSheets andtint(which is where this field used today), I think this is a more sensible fallback for themes without ainitalColorMode.Screenshots
Not applicable.
Test Plan
There shouldn't be any visible changes.