Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort.top.Week using wrong label (sort.top.Hour) #891

Merged
merged 2 commits into from Jul 30, 2023

Conversation

felix-staud
Copy link
Contributor

@felix-staud felix-staud commented Jul 29, 2023

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

fixes a wrong top week label in the feed sort options

Screenshots

Unfortunately I can't test it cause of this error:
image

Test Plan

Take a look at the resolved comments it was quite the easy fix

- fix sort.top.Week showing sort.top.Hour
@gkasdorf gkasdorf merged commit b92d62d into Memmy-App:main Jul 30, 2023
2 checks passed
@felix-staud felix-staud deleted the bug/top-week-wrong-label branch August 1, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants