Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate posts blank spaces #900

Merged

Conversation

joshua-davis-rose
Copy link
Contributor

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

Please provide a summary of what your PR does

When scrolling, occasionally you'd get a repeated page of posts. After scrolling another page you'd see new content again. However, as it turns out there was a missing page in there that you never saw. This also caused collisions with the unique identifiers FlashList uses so you'd get blank spaces in the scroll view.

Screenshots

If the UI has been changed, include screenshots.
We will not review your PR without screenshots if they are applicable.

Nothing new to see.

Test Plan

Please document the steps required to test your PR

Scroll. Scroll fast. Scroll slow. Upvote a post and keep an eye on anything that might get repeated. Look for gaps in the feed.

@sgriff96 sgriff96 requested a review from gkasdorf July 30, 2023 20:58
@gkasdorf gkasdorf merged commit ad84048 into Memmy-App:main Jul 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants