Language fallback #943
Open
Language fallback #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add language fallback method - rename translation files to match <locale>-<Country-Code> pattern
- add writing to log if a language is missing - fix profile translation in Navbar - add some de_DE translations
- adjust stack type
- remove split form languageDetector.ts
- update import names in DayJs.ts
# Conflicts: # Stack.tsx # src/plugins/DayJs.ts # src/plugins/i18n/i18n.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Creator Checklist
Ensure you've checked the following before submitting your PR:
Summary
It implements a logic for fallback languages. Ultimately all languages will fall back to
en-USinstead of showing the raw translation key. That way its still visible if a translation is missing but you can still "understand" it (as long as you know english).It will also now use the full translations code (e.g. en-US, de-DE) if possible but fall back to existing ones (e.g. de-AU will fall back to de-DE)
Screenshots
Nothing changed in the UI..
Test Plan