Skip to content

Commit

Permalink
[osx] - re-enable yadif deinterlacer on osx
Browse files Browse the repository at this point in the history
  • Loading branch information
@Memphiz
Memphiz committed Nov 20, 2014
1 parent ed63cb4 commit 476603a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xbmc/cores/VideoRenderers/LinuxRendererGL.cpp
View file
Expand Up @@ -3379,7 +3379,7 @@ bool CLinuxRendererGL::Supports(EINTERLACEMETHOD method)
return false;
}

#ifdef TARGET_DARWIN
#ifdef TARGET_DARWIN_IOS
// YADIF too slow for HD but we have no methods to fall back
// to something that works so just turn it off.
if(method == VS_INTERLACEMETHOD_DEINTERLACE)

This comment has been minimized.

Sign in to view

Copy link
@fritsch

fritsch Nov 23, 2014

You could check: m_sourceWidth together and if that is <= 720 or m_sourceHeight < 576 you could return true?
Expand Down

4 comments on commit 476603a

@Memphiz
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do this for other platforms and users confirmed that their macs are up to the task. After helix i will enable this for ios too maybe (there was no demand though from ios users)

@fritsch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the "we don't do this for other platforms" reasons. If this would solve an ios specific issue, then it could be done that way, it's #ifdeffed anyways?

@Memphiz
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missunderstood the whole issue. Ios was never involved into the discussion. Yadif was disabled for the whole darwin platform because of osx. Now users/suggest there is no valid reason for it to be disabled anymore for osx. I leave it removed for ios because of making the change as unintrusive as possible. Deinterlacing on ios is mostly only interesting for the atv2 (not many users are running livetv on there touch devices based on forum feedback) - atv2 is not up to the task for yadif - not even sd. I guess i will change/remove the comment to not confuse you even more ;)

fact i don't know how well yadif behaves on ios and am not interested in figuring it out for helix.

@fritsch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! thanks for the explanation, makes sense.

Please sign in to comment.