New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throwing IllegalArgumentException while formatting minimum date of Minguo calendar #792
Comments
Sounds reasonable (minimum effort for making such extreme values formattable which is more important than to support the edge case value itself). |
Similar problem also located in Julian calendar, Thai solar calendar etc. Let's favor formattability for such extrem values. |
I have now extended the general formattability of integer elements up to 10 digits (see issue #797). This solves your problem, too. Do you still insist on adjusting the value ranges of |
No need to adjust the range. Thanks! |
Okay, then I can close this issue, too (indirectly fixed by issue #797). The next release of Time4A is not far away (maybe next week). |
This is kindly FYI that the problem still exists in Time4A version 3.44.4-2018e. |
Will have a look soon... |
Sorry for this oversight. But I have now also added your example as (successful) test case. |
After running the following code
we get
while expecting
1000001911
as output (becauseminDate
is formattable).We suggest to change the minimum date of Minguo calendar to
BEFORE_ROC-999999999-01-01
In other word, we suggest to override
getMinimumSinceUTC
method ofMinguoCalendar
class asThe text was updated successfully, but these errors were encountered: