V4.0 crashes in payload tab

[eku]

I just upgraded from 3.4 to 4.0 and now the application crashes immediately when you select the Payload tab.

Android 7.1

[MenosGrante]

Hm, I will take a look and will get back here with results.

[nerbrume]

Hi, same here, Android 9 (Lineage 16)
Two things that may or may not be relevant :

• it doesn't seem that Rekado requested internet access (it doesn't show up in my soft firewall, AFwall)
• I don't have the GApps installed (no Play services)

Logs are a bit wonky on my phone, but I can try to give you a hopefully relevant excerpt if needed. Tell me.

BTW, thx for Rekado, it saved me a few headaches in the past!

[MenosGrante]

If you have the ability to capture a crash log, that would be perfect, cause currently, I can't reproduce this issue.

[nerbrume]

Here you go,

[04-10 12:05:53.246 20371:20371 E/AndroidRuntime]
FATAL EXCEPTION: main
Process: com.pavelrekun.rekado, PID: 20371
java.net.ConnectException: Failed to connect to pavelrekun.dev/2a03:b0c0:3:e0::26f:c001:443
	at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.kt:285)
	at okhttp3.internal.connection.RealConnection.connect(RealConnection.kt:195)
	at okhttp3.internal.connection.ExchangeFinder.findConnection(ExchangeFinder.kt:249)
	at okhttp3.internal.connection.ExchangeFinder.findHealthyConnection(ExchangeFinder.kt:108)
	at okhttp3.internal.connection.ExchangeFinder.find(ExchangeFinder.kt:76)
	at okhttp3.internal.connection.RealCall.initExchange$okhttp(RealCall.kt:245)
	at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:32)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
	at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:82)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
	at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
	at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
	at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:197)
	at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:502)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)
	Suppressed: java.net.ConnectException: Failed to connect to pavelrekun.dev/68.183.215.91:443
		... 19 more
	Caused by: java.net.ConnectException: failed to connect to pavelrekun.dev/68.183.215.91 (port 443) from /10.0.0.2 (port 37818) after 10000ms: isConnected failed: ECONNREFUSED (Connection refused)
		at libcore.io.IoBridge.isConnected(IoBridge.java:278)
		at libcore.io.IoBridge.connectErrno(IoBridge.java:187)
		at libcore.io.IoBridge.connect(IoBridge.java:129)
		at java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:137)
		at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:390)
		at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:230)
		at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:212)
		at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:436)
		at java.net.Socket.connect(Socket.java:621)
		at okhttp3.internal.platform.AndroidPlatform.connectSocket(AndroidPlatform.kt:57)
		at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.kt:283)
		... 18 more
	Caused by: android.system.ErrnoException: isConnected failed: ECONNREFUSED (Connection refused)
		at libcore.io.IoBridge.isConnected(IoBridge.java:267)
		... 28 more
Caused by: java.net.ConnectException: failed to connect to pavelrekun.dev/2a03:b0c0:3:e0::26f:c001 (port 443) from /fe80::d43:8e10:7477:81dc (port 40594) after 10000ms: isConnected failed: ECONNREFUSED (Connection refused)
	at libcore.io.IoBridge.isConnected(IoBridge.java:278)
	at libcore.io.IoBridge.connectErrno(IoBridge.java:187)
	at libcore.io.IoBridge.connect(IoBridge.java:129)
	at java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:137)
	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:390)
	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:230)
	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:212)
	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:436)
	at java.net.Socket.connect(Socket.java:621)
	at okhttp3.internal.platform.AndroidPlatform.connectSocket(AndroidPlatform.kt:57)
	at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.kt:283)
	... 18 more

[04-10 12:05:53.251 1635:3053 W/ActivityManager]
  Force finishing activity com.pavelrekun.rekado/.containers.PrimaryContainerActivity

[04-10 12:05:53.387 1635:1858 W/InputDispatcher]
channel '9c21a4 com.pavelrekun.rekado/com.pavelrekun.rekado.containers.PrimaryContainerActivity (server)' ~ Consumer closed input channel or an error occurred.  events=0x9

[04-10 12:05:53.387 1635:1858 E/InputDispatcher]
channel '9c21a4 com.pavelrekun.rekado/com.pavelrekun.rekado.containers.PrimaryContainerActivity (server)' ~ Channel is unrecoverably broken and will be disposed!

[04-10 12:05:53.389 1635:3218 I/ActivityManager]
Process com.pavelrekun.rekado (pid 20371) has died: fore TOP 

[04-10 12:05:53.389 1635:15656 I/WindowManager]
WIN DEATH: Window{9c21a4 u0 com.pavelrekun.rekado/com.pavelrekun.rekado.containers.PrimaryContainerActivity}

[04-10 12:05:53.389 1635:15656 W/InputDispatcher]
Attempted to unregister already unregistered input channel '9c21a4 com.pavelrekun.rekado/com.pavelrekun.rekado.containers.PrimaryContainerActivity (server)'

[04-10 12:05:53.397 545:700 W/SurfaceFlinger]
Attempting to set client state on removed layer: com.pavelrekun.rekado/com.pavelrekun.rekado.containers.PrimaryContainerActivity#0

[04-10 12:05:53.397 545:700 W/SurfaceFlinger]
Attempting to destroy on removed layer: com.pavelrekun.rekado/com.pavelrekun.rekado.containers.PrimaryContainerActivity#0

[04-10 12:05:53.405 545:709 W/SurfaceFlinger]
Attempting to destroy on removed layer: AppWindowToken{318e4dc token=Token{a5be54f ActivityRecord{64fa3ae u0 com.pavelrekun.rekado/.containers.PrimaryContainerActivity t7942}}}#0

[MenosGrante]

I see, thanks! It will really hep.

[nerbrume]

Hi again,
Seeing the log is about denied connection, I reinstalled Rekado, which finally showed up in AFwall, so I was able to grant internet access to it, resulting in no more crashes. If I deny it again, it crash.

[eku]

It should not crash if network connection fails.

[MenosGrante]

You are right, I have missed this situation.

[MenosGrante]

I need someone, with this problem to help me check new version of the fix. You can get to me on pavel.rekun.development@gmail.com.

[eku]

@MenosGrante if you provide the fix on a branch, I'll compile and test it.

[MenosGrante]

Yep, give me a minute, I will create branch - "develop/4.1".

UPD: @eku, branch created.

[MenosGrante]

Hi @eku, did you have a chance to test it?

[eku]

@MenosGrante I commented your commit on the branch.

[MenosGrante]

@eku, in the latest commit to 4.1 branch I have changed OkHTTP to Retrofit (which is working better with coroutines and error handling), so crash should be eliminated now.

[MenosGrante]

Fixed in the 4.1 update.