Attachments: dedupe earlier to prevent incorrect max_media (Automatti…

…c#565)
Menrath · Nov 17, 2023 · c35ddf1 · c35ddf1
1 parent 21206ec
commit c35ddf1
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/includes/transformer/class-post.php b/includes/transformer/class-post.php
@@ -185,7 +185,6 @@ protected function get_block_attachments( $max_media ) {
 			$blocks = \parse_blocks( $this->wp_post->post_content );
 			$media_ids = self::get_media_ids_from_blocks( $blocks, $media_ids, $max_media );
 		}
-		$media_ids = \array_unique( $media_ids );
 
 		return \array_filter( \array_map( array( self::class, 'wp_attachment_to_activity_attachment' ), $media_ids ) );
 	}
@@ -279,6 +278,9 @@ protected static function get_media_ids_from_blocks( $blocks, $media_ids, $max_m
 					break;
 			}
 
+			// depupe
+			$media_ids = \array_unique( $media_ids );
+
 			// stop doing unneeded work
 			if ( count( $media_ids ) >= $max_media ) {
 				break;