[1.20.1] Add missing loot modifier registration #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 1.20.1 Forge, the loot modifier wasn't registered, and thus the smithing template couldn't be found in end cities.
Relevant log (line 59) of the situation in the current release: https://mclo.gs/3VxZvsg
The IsSpecificLootTable condition wasn't registered either, but there's a forge equivalent for it that I've used instead; it checks only one id, but you can chain these together using vanilla datapack mechanics.
I believe the class for it can safely be removed but I've left that out of the PR (let me know if you'd like that)