Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename function factories create_cut() and create_test() #221

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

jdblischak
Copy link
Collaborator

@jdblischak jdblischak commented Mar 19, 2024

Follow-up to #201 and #215.

Based on our internal discussion on how to name these functions, I propose renaming the function factories create_cut() and create_test(), and renaming their corresponding sim_gs_n() arguments to cuts cut and tests test.

@keaven
Copy link
Collaborator

keaven commented Mar 19, 2024

Concept is great. I have not reviewed code or tests.

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jdblischak ! I only have 1 minor comment.

R/sim_gs_n.R Outdated Show resolved Hide resolved
R/sim_gs_n.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's get this merged! I appreciate the simplification efforts

@nanxstats nanxstats merged commit c57904f into Merck:main Mar 25, 2024
7 checks passed
@jdblischak jdblischak deleted the renaming-cut-test branch March 25, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants