Skip to content

Commit

Permalink
s/gen_uint/generate_uint/g, per review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
markbrown committed Aug 27, 2019
1 parent fcdfc5c commit 0f1c298
Show file tree
Hide file tree
Showing 10 changed files with 171 additions and 171 deletions.
24 changes: 12 additions & 12 deletions extras/random/binfile.m
Expand Up @@ -43,10 +43,10 @@
%
% Throws an exception if the end-of-file is reached.
%
:- pred gen_uint8(binfile::in, uint8::out, io::di, io::uo) is det.
:- pred gen_uint16(binfile::in, uint16::out, io::di, io::uo) is det.
:- pred gen_uint32(binfile::in, uint32::out, io::di, io::uo) is det.
:- pred gen_uint64(binfile::in, uint64::out, io::di, io::uo) is det.
:- pred generate_uint8(binfile::in, uint8::out, io::di, io::uo) is det.
:- pred generate_uint16(binfile::in, uint16::out, io::di, io::uo) is det.
:- pred generate_uint32(binfile::in, uint32::out, io::di, io::uo) is det.
:- pred generate_uint64(binfile::in, uint64::out, io::di, io::uo) is det.

%---------------------------------------------------------------------------%

Expand All @@ -61,10 +61,10 @@
---> binfile(binary_input_stream).

:- instance urandom(binfile, io) where [
pred(gen_uint8/4) is binfile.gen_uint8,
pred(gen_uint16/4) is binfile.gen_uint16,
pred(gen_uint32/4) is binfile.gen_uint32,
pred(gen_uint64/4) is binfile.gen_uint64
pred(generate_uint8/4) is binfile.generate_uint8,
pred(generate_uint16/4) is binfile.generate_uint16,
pred(generate_uint32/4) is binfile.generate_uint32,
pred(generate_uint64/4) is binfile.generate_uint64
].

%---------------------------------------------------------------------------%
Expand All @@ -84,7 +84,7 @@

%---------------------------------------------------------------------------%

gen_uint8(binfile(Stream), N, !IO) :-
generate_uint8(binfile(Stream), N, !IO) :-
io.read_binary_uint8(Stream, Res, !IO),
(
Res = ok(N)
Expand All @@ -96,15 +96,15 @@
unexpected($pred, io.error_message(E))
).

gen_uint16(binfile(Stream), N, !IO) :-
generate_uint16(binfile(Stream), N, !IO) :-
io.read_binary_uint16_be(Stream, Res, !IO),
handle_res(Res, N).

gen_uint32(binfile(Stream), N, !IO) :-
generate_uint32(binfile(Stream), N, !IO) :-
io.read_binary_uint32_be(Stream, Res, !IO),
handle_res(Res, N).

gen_uint64(binfile(Stream), N, !IO) :-
generate_uint64(binfile(Stream), N, !IO) :-
io.read_binary_uint64_be(Stream, Res, !IO),
handle_res(Res, N).

Expand Down
32 changes: 16 additions & 16 deletions extras/random/marsaglia.m
Expand Up @@ -39,10 +39,10 @@
% Generate a uniformly distributed pseudo-random unsigned integer
% of 8, 16, 32 or 64 bytes, respectively.
%
:- pred gen_uint8(uint8::out, random::in, random::out) is det.
:- pred gen_uint16(uint16::out, random::in, random::out) is det.
:- pred gen_uint32(uint32::out, random::in, random::out) is det.
:- pred gen_uint64(uint64::out, random::in, random::out) is det.
:- pred generate_uint8(uint8::out, random::in, random::out) is det.
:- pred generate_uint16(uint16::out, random::in, random::out) is det.
:- pred generate_uint32(uint32::out, random::in, random::out) is det.
:- pred generate_uint64(uint64::out, random::in, random::out) is det.

%---------------------------------------------------------------------------%

Expand All @@ -59,10 +59,10 @@
---> random(uint64).

:- instance random(random) where [
pred(gen_uint8/3) is marsaglia.gen_uint8,
pred(gen_uint16/3) is marsaglia.gen_uint16,
pred(gen_uint32/3) is marsaglia.gen_uint32,
pred(gen_uint64/3) is marsaglia.gen_uint64
pred(generate_uint8/3) is marsaglia.generate_uint8,
pred(generate_uint16/3) is marsaglia.generate_uint16,
pred(generate_uint32/3) is marsaglia.generate_uint32,
pred(generate_uint64/3) is marsaglia.generate_uint64
].

init = seed(0u32, 0u32).
Expand All @@ -74,26 +74,26 @@

%---------------------------------------------------------------------------%

gen_uint8(N, !R) :-
marsaglia.gen_uint32(N0, !R),
generate_uint8(N, !R) :-
marsaglia.generate_uint32(N0, !R),
N1 = uint32.cast_to_int(N0 >> 24),
N = uint8.cast_from_int(N1).

gen_uint16(N, !R) :-
marsaglia.gen_uint32(N0, !R),
generate_uint16(N, !R) :-
marsaglia.generate_uint32(N0, !R),
N1 = uint32.cast_to_int(N0 >> 16),
N = uint16.cast_from_int(N1).

gen_uint64(N, !R) :-
marsaglia.gen_uint32(A0, !R),
marsaglia.gen_uint32(B0, !R),
generate_uint64(N, !R) :-
marsaglia.generate_uint32(A0, !R),
marsaglia.generate_uint32(B0, !R),
A = uint32.cast_to_uint64(A0),
B = uint32.cast_to_uint64(B0),
N = A + (B << 32).

%---------------------------------------------------------------------------%

gen_uint32(N, R0, R) :-
generate_uint32(N, R0, R) :-
R0 = random(S0),
unpack_uint64(S0, SX0, SY0),
A = 18000u32,
Expand Down
34 changes: 17 additions & 17 deletions extras/random/tausworthe.m
Expand Up @@ -67,10 +67,10 @@
% Throws an exception if the params and ustate are not the same size
% (i.e., both 3-combo or both 4-combo).
%
:- pred gen_uint8(params::in, uint8::out, ustate::di, ustate::uo) is det.
:- pred gen_uint16(params::in, uint16::out, ustate::di, ustate::uo) is det.
:- pred gen_uint32(params::in, uint32::out, ustate::di, ustate::uo) is det.
:- pred gen_uint64(params::in, uint64::out, ustate::di, ustate::uo) is det.
:- pred generate_uint8(params::in, uint8::out, ustate::di, ustate::uo) is det.
:- pred generate_uint16(params::in, uint16::out, ustate::di, ustate::uo) is det.
:- pred generate_uint32(params::in, uint32::out, ustate::di, ustate::uo) is det.
:- pred generate_uint64(params::in, uint64::out, ustate::di, ustate::uo) is det.

% Duplicate a tausworthe RNG state.
%
Expand Down Expand Up @@ -105,10 +105,10 @@
).

:- instance urandom(params, ustate) where [
pred(gen_uint8/4) is tausworthe.gen_uint8,
pred(gen_uint16/4) is tausworthe.gen_uint16,
pred(gen_uint32/4) is tausworthe.gen_uint32,
pred(gen_uint64/4) is tausworthe.gen_uint64
pred(generate_uint8/4) is tausworthe.generate_uint8,
pred(generate_uint16/4) is tausworthe.generate_uint16,
pred(generate_uint32/4) is tausworthe.generate_uint32,
pred(generate_uint64/4) is tausworthe.generate_uint64
].

:- instance urandom_dup(ustate) where [
Expand All @@ -123,26 +123,26 @@

%---------------------------------------------------------------------------%

gen_uint8(RP, N, !RS) :-
tausworthe.gen_uint32(RP, N0, !RS),
generate_uint8(RP, N, !RS) :-
tausworthe.generate_uint32(RP, N0, !RS),
N1 = uint32.cast_to_int(N0 >> 24),
N = uint8.cast_from_int(N1).

gen_uint16(RP, N, !RS) :-
tausworthe.gen_uint32(RP, N0, !RS),
generate_uint16(RP, N, !RS) :-
tausworthe.generate_uint32(RP, N0, !RS),
N1 = uint32.cast_to_int(N0 >> 16),
N = uint16.cast_from_int(N1).

gen_uint64(RP, N, !RS) :-
tausworthe.gen_uint32(RP, A0, !RS),
tausworthe.gen_uint32(RP, B0, !RS),
generate_uint64(RP, N, !RS) :-
tausworthe.generate_uint32(RP, A0, !RS),
tausworthe.generate_uint32(RP, B0, !RS),
A = uint32.cast_to_uint64(A0),
B = uint32.cast_to_uint64(B0),
N = A + (B << 32).

%---------------------------------------------------------------------------%

gen_uint32(RP, N, RS0, RS) :-
generate_uint32(RP, N, RS0, RS) :-
RS0 = ustate(Seed0),
Size = array.size(Seed0),
rand(RP, 0, Size, 0u32, N, Seed0, Seed),
Expand Down Expand Up @@ -182,7 +182,7 @@
seed_2(0, Size, Ks, Ps, Ds, Shft0, Shft, Mask0, Mask, Seed0, Seed),
RP = params(Qs, Ps, Shft, Mask),
RS0 = unsafe_promise_unique(ustate(Seed)),
tausworthe.gen_uint32(RP, _, RS0, RS).
tausworthe.generate_uint32(RP, _, RS0, RS).

:- pred seed_2(int::in, int::in, array(int)::in, array(int)::in,
array(uint32)::in, array(int)::array_di, array(int)::array_uo,
Expand Down

0 comments on commit 0f1c298

Please sign in to comment.