[DUX-1066] Fix --command with nix develop
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
changed the title
--command with nix develop--command with nix develop
DUX-1066 Allow passing arguments to `nix develop` in `nix-your-shell`
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nix CLI is inconsistent with the
--commandflag...We would transform (e.g.)
nix develop -L .#ghc942intonix develop --command fish -L .#ghc942, which Nix interprets as running the commandfish -L .#ghc942in the shell. This patch puts the--command fishbit at the end, instead of at the front, so the-L .#ghc942arguments are correctly passed tonix develop.Future work: actually writing some tests lol