Do paged conversation lists; change the pager to be generic over types #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lf-
force-pushed
the
jadel/pager-improvements
branch
from
9531ecf
to
341653a
Compare
lf-
commented
Oct 4, 2022
Comment on lines
+19
to
+25
| class PagedRequest a where | ||
| setCursor :: Maybe Cursor -> a -> a | ||
|
|
||
| class PagedResponse a where | ||
| type ResponseObject a | ||
| getResponseMetadata :: a -> Maybe ResponseMetadata | ||
| getResponseData :: a -> [ResponseObject a] |
There was a problem hiding this comment.
I designed it this way since there is no binding between request and response types; two requests may reuse the same response.
Comment on lines
-22
to
-53
| import Web.Slack.Types (Cursor) | ||
| import Prelude | ||
|
|
||
| -- | Public only for testing. | ||
| conversationsHistoryAllBy :: | ||
| MonadIO m => | ||
| -- | Response generator | ||
| (Conversation.HistoryReq -> m (Response Conversation.HistoryRsp)) -> | ||
| -- | The first request to send. _NOTE_: 'Conversation.historyReqCursor' is silently ignored. | ||
| Conversation.HistoryReq -> | ||
| -- | An action which returns a new page of messages every time called. | ||
| -- If there are no pages anymore, it returns an empty list. | ||
| m (LoadPage m Common.Message) | ||
| conversationsHistoryAllBy sendRequest initialRequest = | ||
| genericFetchAllBy | ||
| sendRequest | ||
| (\cursor -> initialRequest {Conversation.historyReqCursor = cursor}) | ||
|
|
||
| -- | Public only for testing. | ||
| repliesFetchAllBy :: | ||
| MonadIO m => | ||
| -- | Response generator | ||
| (Conversation.RepliesReq -> m (Response Conversation.HistoryRsp)) -> | ||
| -- | The first request to send. _NOTE_: 'Conversation.historyReqCursor' is silently ignored. | ||
| Conversation.RepliesReq -> | ||
| -- | An action which returns a new page of messages every time called. | ||
| -- If there are no pages anymore, it returns an empty list. | ||
| m (LoadPage m Common.Message) | ||
| repliesFetchAllBy sendRequest initialRequest = | ||
| genericFetchAllBy | ||
| sendRequest | ||
| (\cursor -> initialRequest {Conversation.repliesReqCursor = cursor}) |
dsh
approved these changes
Oct 4, 2022
|
|
||
| instance NFData ResponseMetadata | ||
|
|
||
| $(deriveJSON (jsonOpts "responseMetadata") ''ResponseMetadata) |
There was a problem hiding this comment.
This is simple enough write the instances without the Template Haskell overhead?
Or this is simple enough the Template Haskell overhead doesn't matter?
There was a problem hiding this comment.
The main motivation is that it was moved. I would rather take the TH overhead than do it inconsistently, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to do paged conversation lists for slacklinker, since I expect I will have a lot of conversations to go through.
This meant that the existing pager stuff that was hardcoded to one response type needed to fixed. So I fixed it by deleting a bunch of duplicated code by making it generic.