Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared-channel Conversation parse; improve Conversation parse errors #108

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Fix shared-channel Conversation parse; improve Conversation parse errors #108

merged 3 commits into from
Nov 4, 2022

Commits on Nov 4, 2022

  1. Fix shared-channel Conversation parse; improve Conversation parse errors 

    This bug was found using the conversationsList endpoint, in which our parse
failed on a shared channel.

I have committed an anonymized version of the bad part of the response
as a regression test, and fixed the error messages for Conversations
matching a variant but failing to parse that variant.
    Jade Lovelace committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    11f169f View commit details
    Browse the repository at this point in the history

  2. Delete *.actual files that should not have been added

    Jade Lovelace committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2ed0380 View commit details
    Browse the repository at this point in the history

  3. Delete now-unnecessary ghc-9.4 overrides

    Jade Lovelace committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    055d95c View commit details
    Browse the repository at this point in the history