Parse file share events #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My client code was really nasty and I reconsidered this decision in short order.
evanrelf
approved these changes
Dec 14, 2022
| @@ -116,6 +116,14 @@ | |||
| # 0.6.3 in the repo | |||
| refined = hfinal.refined_0_7; | |||
|
|
|||
| pretty-simple = hfinal.callHackageDirect | |||
There was a problem hiding this comment.
Woah TIL about callHackageDirect, I've been updating all-cabal-hashes like a dummy.
There was a problem hiding this comment.
i can't be bothered to deal with that on slack-web, so I don't. XD
all-cabal-hashes updating is a much better strategy if you have a lot of packages.
lf-
pushed a commit
that referenced
this pull request
Dec 15, 2022
Based on #120. Before submitting your PR, check that you've: - [x] Documented new APIs with [Haddock markup](https://www.haskell.org/haddock/doc/html/index.html) - [x] Added [`@since` declarations](http://haskell-haddock.readthedocs.io/en/latest/markup.html#since) to the Haddock After submitting your PR: - [x] Update the Changelog.md file with a link to your PR - [x] Bumped the version number if there isn't an `(unreleased)` on the Changelog - [ ] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts) <!---Thanks so much for contributing! :) _If these checkboxes don't apply to your PR, you can delete them_-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
Bumped the version number if there isn't anGoing to release with the next PR(unreleased)on the Changelog