Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Slack email objects without exploding #124

Merged
merged 2 commits into from Dec 16, 2022
Merged

Parse Slack email objects without exploding #124

merged 2 commits into from Dec 16, 2022

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Dec 16, 2022 •
edited

We really should have expected that Slack didn't document all the types of file. 🤦‍♀️

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Jade Lovelace added 2 commits December 16, 2022 12:04
Parse Slack email objects without exploding
7d881d3 
We really should have expected that Slack didn't document all the types
of file. 🤦‍♀️
ChangeLog
399dbc3
@lf- lf- requested a review from friedbrice December 16, 2022 20:06
Gabriella439
Gabriella439 approved these changes Dec 16, 2022
View reviewed changes
slack-web.cabal
@@ -8,8 +8,8 @@ license: MIT
license-file: LICENSE.md

copyright: 2017 Juan Pedro Villa Isaza, 2022 Mercury Technologies, Inc
author: Juan Pedro Villa Isaza <jpvillaisaza@gmail.com>, Jade Lovelace <jadel@mercury.com>, Dennis Hennen <dennis@mercury.com>
maintainer: Jade Lovelace <jadel@mercury.com>
author: Juan Pedro Villa Isaza <jpvillaisaza@gmail.com>, Jade Lovelace <software at lfcode dot ca>, Dennis Hennen <dennis@mercury.com>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@lf- lf- merged commit 319118c into master Dec 16, 2022
@lf- lf- deleted the jadel/emails-parse branch December 16, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

@friedbrice friedbrice Awaiting requested review from friedbrice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lf- @Gabriella439