Add a bunch of warnings flags, expose an Internal module #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lf-
commented
Sep 29, 2022
Comment on lines
-63
to
-69
| #if MIN_VERSION_servant(0,16,0) | ||
| import Servant.Client.Core (AuthClientData, AuthenticatedRequest, Request, mkAuthenticatedRequest, addHeader) | ||
| #else | ||
| import Servant.Client.Core.Internal.Auth | ||
| import Servant.Client.Core (Request, addHeader) | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I dropped the old versions since I don't sincerely believe that we are likely to correctly support them.
| @@ -369,50 +328,6 @@ apiTest_ | |||
| = | |||
| client (Proxy :: Proxy Api) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
this code block was moved to Web.Slack.Internal
friedbrice
reviewed
Sep 29, 2022
Comment on lines
+35
to
+36
| -- Requires explicit imports of _every_ function (e.g. '$'); too strict | ||
| -Wno-missing-import-lists |
There was a problem hiding this comment.
In Purescript they thought about this. They allow you to have exactly zero or one unqualified import that doesn't have an explicit import list 😆
There was a problem hiding this comment.
clever!
I just copied the Mercury list :p
friedbrice
reviewed
Sep 29, 2022
Comment on lines
+120
to
+121
| , mono-traversable | ||
| , classy-prelude |
There was a problem hiding this comment.
i really hate these libraries <.<
friedbrice
reviewed
Sep 29, 2022
| @@ -1,7 +1,6 @@ | |||
| {-# LANGUAGE DataKinds #-} | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
| {-# LANGUAGE TypeFamilies #-} | |||
| {-# LANGUAGE CPP #-} | |||
friedbrice
reviewed
Sep 29, 2022
Comment on lines
1
to
3
| {-# LANGUAGE DataKinds #-} | ||
| {-# LANGUAGE OverloadedStrings #-} | ||
| {-# LANGUAGE TypeFamilies #-} |
There was a problem hiding this comment.
I think hlint will tell you when a file has redundant language extensions. I'm not sure if it takes your `default-extensions into account.
Suggested change
| {-# LANGUAGE DataKinds #-} | |
| {-# LANGUAGE OverloadedStrings #-} | |
| {-# LANGUAGE TypeFamilies #-} | |
| {-# LANGUAGE DataKinds #-} | |
| {-# LANGUAGE OverloadedStrings #-} | |
| {-# LANGUAGE TypeFamilies #-} |
friedbrice
approved these changes
Sep 29, 2022
lf-
pushed a commit
that referenced
this pull request
Sep 29, 2022
This is based on #99. This code is copied (with approval) from the Mercury codebase, with no code modifications except for making `SlackActionId` a `newtype` rather than a sum type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal module is necessary to allow extending the library, and the warnings improve reliability.