bug fix in extension hard-disabling/enabling in mush #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes two things: 1. verifies the variable `extid` is actually an extension ID 2. makes sure typing an invalid input doesnt remove your perms for your user's entire extension folder (since there was no check on the `extid` variable, it would run `chmod 000` on "/home/chronos/user/Extensions/$extid" even if $extid is unset, meaning the chmod command was run on the "/home/chronos/user/Extensions/" directory as a whole)
tuocan
changed the title
|
torcan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes two things:
extidis actually an extension IDextidvariable, it would runchmod 000on "/home/chronos/user/Extensions/$extid" even if $extid is unset, meaning the chmod command was run on the "/home/chronos/user/Extensions/" directory as a whole)