Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Google DNS with Quad9 for example #8

Closed
Hoerli1337 opened this issue Jan 19, 2024 · 2 comments
Closed

Replace Google DNS with Quad9 for example #8

Hoerli1337 opened this issue Jan 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Hoerli1337
Copy link

Hi!
Would it perhaps be possible to swap the Google DNS via HTTPS server for Quad9, for example?
Quad9 is a bit better in terms of data protection and Google doesn't always have to know everything.

If I have found this correctly, the entry in TMessagesProj\src\main\java\org\telegrams\tgnet\ConnectionsManager.java only needs to be changed from dns.google.com (line 947 + 1061 + 1178) to dns.quad9.net + https://dns.quad9.net/dns-query or https://dns11.quad9.net/dns-query.

An entry in the settings to freely determine the DNS server would of course be extremely great! :)

@drizzt drizzt added the enhancement New feature or request label Jan 19, 2024
@drizzt
Copy link
Collaborator

drizzt commented Jan 19, 2024

It's not so simple, telegram uses the deprecated implementation of DNS over HTTPS that quad9 doesn't support anymore.

You can easily test that:

tredaell@aldebaran ~ ₿ curl -s "https://dns.google.com/resolve?name=www.google.it&type=A"
{"Status":0,"TC":false,"RD":true,"RA":true,"AD":false,"CD":false,"Question":[{"name":"www.google.it.","type":1}],"Answer":[{"name":"www.google.it.","type":1,"TTL":300,"data":"142.250.180.131"}],"Comment":"Response from 216.239.34.10."}
tredaell@aldebaran ~ ₿ curl -s "https://dns.quad9.net/dns-query?name=www.google.it&type=A"
Unable to find the DNS parameter
tredaell@aldebaran ~ ₿

quad9 supports the deprecated implementation only on port 5053

tredaell@aldebaran ~ ₿ curl -s "https://dns.quad9.net:5053/dns-query?name=www.google.it&type=A"
{"Status":0,"TC":false,"RD":true,"RA":true,"AD":false,"CD":false,"Question":[{"name":"www.google.it.","type":1}],"Answer":[{"name":"www.google.it.","type":1,"TTL":294,"Expires":"Fri, 19 Jan 2024 18:02:48 UTC","data":"142.250.186.99"}]}
tredaell@aldebaran ~ ₿

but using port 5353 is bad since dns over https is ONLY used to bypass some firewalls when the usual DNS doesn't work.

I'll accept any PR that implements the current RFC8484 with quad9

@drizzt
Copy link
Collaborator

drizzt commented Jan 19, 2024

DOH is completely disabled in 10.6.1.1, so we can close this.

@drizzt drizzt closed this as completed Jan 19, 2024
drizzt pushed a commit that referenced this issue Jan 19, 2024
USE_DELEGATE_HOST_RESOLVE enables resolving proxy hosts by using Google
DNS (HTTPS) servers.

Since this leaks privacy and it's absolutely not needed (Android 9+
supports DNS-over-TLS that should be used instead), just disable it.
drizzt pushed a commit that referenced this issue Jan 29, 2024
USE_DELEGATE_HOST_RESOLVE enables resolving proxy hosts by using Google
DNS (HTTPS) servers.

Since this leaks privacy and it's absolutely not needed (Android 9+
supports DNS-over-TLS that should be used instead), just disable it.
drizzt pushed a commit that referenced this issue Jan 29, 2024
USE_DELEGATE_HOST_RESOLVE enables resolving proxy hosts by using Google
DNS (HTTPS) servers.

Since this leaks privacy and it's absolutely not needed (Android 9+
supports DNS-over-TLS that should be used instead), just disable it.
drizzt pushed a commit that referenced this issue Mar 21, 2024
USE_DELEGATE_HOST_RESOLVE enables resolving proxy hosts by using Google
DNS (HTTPS) servers.

Since this leaks privacy and it's absolutely not needed (Android 9+
supports DNS-over-TLS that should be used instead), just disable it.
drizzt pushed a commit that referenced this issue Apr 22, 2024
USE_DELEGATE_HOST_RESOLVE enables resolving proxy hosts by using Google
DNS (HTTPS) servers.

Since this leaks privacy and it's absolutely not needed (Android 9+
supports DNS-over-TLS that should be used instead), just disable it.
drizzt pushed a commit that referenced this issue May 16, 2024
USE_DELEGATE_HOST_RESOLVE enables resolving proxy hosts by using Google
DNS (HTTPS) servers.

Since this leaks privacy and it's absolutely not needed (Android 9+
supports DNS-over-TLS that should be used instead), just disable it.
drizzt pushed a commit that referenced this issue May 17, 2024
USE_DELEGATE_HOST_RESOLVE enables resolving proxy hosts by using Google
DNS (HTTPS) servers.

Since this leaks privacy and it's absolutely not needed (Android 9+
supports DNS-over-TLS that should be used instead), just disable it.
drizzt pushed a commit that referenced this issue May 21, 2024
USE_DELEGATE_HOST_RESOLVE enables resolving proxy hosts by using Google
DNS (HTTPS) servers.

Since this leaks privacy and it's absolutely not needed (Android 9+
supports DNS-over-TLS that should be used instead), just disable it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants