Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applyChangeset fails if a trigger contains space #137

Closed
wonder-sk opened this issue Jul 22, 2021 · 0 comments · Fixed by #141
Closed

applyChangeset fails if a trigger contains space #137

wonder-sk opened this issue Jul 22, 2021 · 0 comments · Fixed by #141
Assignees
@wonder-sk
Labels
bug Something isn't working

Comments

@wonder-sk
Copy link
Contributor

In SqliteDriver::applyChangeset() the statement to drop trigger does not escape the name, so it fails if the trigger name is e.g.:

Hello world_zoom_insert
@wonder-sk wonder-sk added the bug Something isn't working label Jul 22, 2021
wonder-sk added a commit that referenced this issue Jul 27, 2021
@wonder-sk
Fix error in applyChangeset when a trigger contains space (fixes #137)
df922bd
wonder-sk added a commit that referenced this issue Jul 27, 2021
@wonder-sk
Fix error in applyChangeset when a trigger contains space (fixes #137)
1d66bae
@wonder-sk wonder-sk mentioned this issue Jul 27, 2021
Merged
wonder-sk added a commit that referenced this issue Jul 27, 2021
@wonder-sk
Fix error in applyChangeset when a trigger contains space (fixes #137)
42cedca
@wonder-sk wonder-sk mentioned this issue Aug 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wonder-sk wonder-sk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error in applyChangeset when a trigger contains space MerginMaps/geodiff
1 participant
@wonder-sk