-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applyChangeset does not ignore meta tables #138
Labels
bug
Something isn't working
Comments
Downstream issue: MerginMaps/qgis-plugin#279 |
wonder-sk
added a commit
that referenced
this issue
Jul 27, 2021
When using a mix of pre-1.0 geodiff (includes changes in metatables) and post-1.0 geodiff (ignores changes in metatables), sqlite driver's apply changeset function did not ignore metatables, causing issues in mergin plugin when updating basefiles.
Is it fixing the downstream issue too, or just partially fixing it? |
wonder-sk
added a commit
that referenced
this issue
Jul 27, 2021
When using a mix of pre-1.0 geodiff (includes changes in metatables) and post-1.0 geodiff (ignores changes in metatables), sqlite driver's apply changeset function did not ignore metatables, causing issues in mergin plugin when updating basefiles.
It should completely fix it, I will close the downstream ticket separately when upgrading to newer pygeodiff / mergin-client |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In sqlite driver, we should be ignoring any changes to
gkg_*
tables - we ignore them already when creating changesets, but older versions of geodiff include them in the changesets.Because of this, currently we sometimes get conflicts when trying to update a geopackage with diff from pre-1.0 geodiff using a new version of geodiff - for example, gpkg_contents table should have last modified date/time updated, but the "old" value in diff does not match the current value.
The text was updated successfully, but these errors were encountered: