Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres driver: errors when timestamp column uses fractions of seconds #186

Closed
wonder-sk opened this issue Aug 16, 2022 · 0 comments · Fixed by #188
Closed

postgres driver: errors when timestamp column uses fractions of seconds #186

wonder-sk opened this issue Aug 16, 2022 · 0 comments · Fixed by #188
Labels
bug Something isn't working

Comments

@wonder-sk
Copy link
Contributor

When using a column of timestamp without time zone type and the date/time values have higher precision than seconds, things do not work correctly:

  • dump of table data will create a diff with values truncated to whole seconds (see allColumnNames() in postgresdriver.cpp)
  • if such dump is applied to a different schema and then the two schemas are compared, geodiff will emit update entries (because the original value and new value are not the same), but the entries will not contain any actual changes (only primary key column is listed in the entry) - I would consider such diff invalid
  • if a diff from the previous point gets applied, that operation fails (Incorrect SQL query when there are no updates in the PostgreSQL table #181)

Ideally we would want to preserve full original values if possible. And if we need to modify how date/time values are stored in diffs, we should verify the change is backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant