address review

MerginMaps · Feb 2, 2023 · bfc7985 · bfc7985 · inputapp-bot · Feb 2, 2023
1 parent 1b07de1
commit bfc7985
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 12 deletions.
diff --git a/app/attributes/attributecontroller.cpp b/app/attributes/attributecontroller.cpp
@@ -458,7 +458,6 @@ void AttributeController::updateOnFeatureChange()
         {
           mFeatureLayerPair.featureRef().setAttribute( fieldIndex, rememberedValue );
           itemData->setRawValue( rememberedValue );
-          emit formDataChanged( itemData->id(), { AttributeFormModel::RawValue } );
         }
       }
     }
@@ -1120,7 +1119,6 @@ bool AttributeController::setFormValue( const QUuid &id, QVariant value )
 
     item->setRawValue( val );
     emit formDataChanged( item->id(), { AttributeFormModel::RawValue } );
-    emit rawValueChanged();
 
     if ( !field.convertCompatible( val ) )
     {

diff --git a/app/attributes/attributecontroller.h b/app/attributes/attributecontroller.h
@@ -167,7 +167,6 @@ class  AttributeController : public QObject
     void featureIdChanged();
     void changesCommited();
     void commitFailed();
-    void rawValueChanged();
 
   private:
     void clearAll();

diff --git a/app/attributes/fieldvalidator.cpp b/app/attributes/fieldvalidator.cpp
@@ -35,7 +35,6 @@ FieldValidator::ValidationStatus FieldValidator::validate( const FeatureLayerPai
   ValidationStatus state = Valid;
 
   const QgsField field = item.field();
-  //QVariant value = pair.feature().attribute( item.fieldIndex() );
   QVariant value = item.rawValue();
 
   bool isNumeric = item.editorWidgetType() == QStringLiteral( "Range" ) || field.isNumeric();

diff --git a/app/qml/editor/inputtextedit.qml b/app/qml/editor/inputtextedit.qml
@@ -66,14 +66,6 @@ AbstractEditor {
       if ( field.isNumeric )
       {
         val = val.replace( ",", "." ).replace( / /g, '' ) // replace comma with dot and remove spaces
-
-        let endsWithDecimalSeparator = val.endsWith('.');
-        let hasOnlyOneDecimalSeparator = val.split('.').length === 2;
-
-        if ( endsWithDecimalSeparator && hasOnlyOneDecimalSeparator )
-        {
-          return; // do not send value changed signal when number ends with decimal separator
-        }
       }
 
       editorValueChanged( val, val === "" )