fix entering negative values in range field #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasMizera
requested changes
Feb 20, 2023
There was a problem hiding this comment.
@alexbruy please provide the following
- description
- auto tests
- explanation why this is needed
This piece of code looks dangerous as it effectively returns rawValue when someone asks for AttributeValue in attributeformmodel https://github.com/MerginMaps/input/blob/1b7c002f0e4eefdf183222721f996c5f17353b75/app/attributes/attributeformmodel.cpp#L60 What is the reason to return the rawValue?
|
Can you provide guidelines on how should I test UI behaviour? |
alexbruy
force-pushed
the
fix-negative-number
branch
from
14025f7
to
aa91c50
Compare
tomasMizera
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes enetering of minus sign in the range field, as per https://app.clickup.com/t/861mctcbe