Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo orientation for preview panel #2633

Merged
merged 1 commit into from Mar 17, 2023
Merged

Conversation

saberraz
Copy link
Contributor

@saberraz saberraz commented Mar 14, 2023

Since qt 6.2, it is possible to use autotransform to change the photo orientation:
https://doc.qt.io/qt-6.2/qml-qtquick-image.html#autoTransform-prop

This should fix the image orientation issue in the preview panel.

fixes #2632

@PeterPetrik
Copy link
Contributor

@saberraz can you share the project from the bug report so we can test it? Have you tested it with the fix ?

@saberraz
Copy link
Contributor Author

saberraz commented Mar 14, 2023

@PeterPetrik yes, I have shared the project with support:
https://app.merginmaps.com/projects/saber/Photo-orientation

Here is before this PR:
image

Here is after:
Screenshot_20230314-150358_Mergin_Maps

@PeterPetrik
Copy link
Contributor

do you have photo with banana for size comparison?

@jozef-budac maybe worth to add to testing?

@PeterPetrik PeterPetrik self-requested a review March 14, 2023 16:02
@PeterPetrik PeterPetrik changed the title fixes #2632 Photo orientation for preview panel Mar 14, 2023
@jozef-budac
Copy link

Just to be sure, in this PR, input will automatically fix the orientation of the image? Based on what attribute or characteristics it is going to decide that?

@PeterPetrik
Copy link
Contributor

based on EXIF info; output is that if you take image landscape/portrait it will always be shown correct way in preview panel

@jozef-budac
Copy link

@saberraz can you share the project also with jozebudac account? And can I create a clone of that project and make it public for testing purposes?

@Tadeo98
Copy link

Tadeo98 commented Mar 17, 2023

Tested and it indeed fixed the orientation issue.

@tomasMizera tomasMizera merged commit 8b589be into master Mar 17, 2023
9 checks passed
@tomasMizera tomasMizera deleted the fix-preview-panel-rotation branch March 17, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview panel does not adjust transformation
6 participants