New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch features in background threads #2701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonder-sk
reviewed
May 29, 2023
wonder-sk
approved these changes
May 31, 2023
PeterPetrik
changed the title
Fetch features in bakground threads
Fetch features in background threads
Jun 13, 2023
tomasMizera
reviewed
Jul 3, 2023
Hi @uclaros, can you please rebase this PR? You will get a new certificate for iOS and its build should work fine then |
tomasMizera
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2211
There were two reasons for the slowness:
totalFields
xtotalFeatures
~
regex operator, which makes 1. even worseTo mitigate this:
layer.getFeatures()
is ran on a background thread usingQtConcurent::run()
~
which is super slow to theilike
operator.Drawbacks:
#2045 may be easier to hit, as with adequate
number of fields
+fields names length
sqlite hits aparser stack overflow
and we get no results at all.We can address this on a separate PR by requesting all features from the layer and do the matching ourselves.
In that case, the request will only include the relation related expression and not the search filter expression.