Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show layer attribution #2702

Merged
merged 10 commits into from Jul 24, 2023
Merged

Show layer attribution #2702

merged 10 commits into from Jul 24, 2023

Conversation

alexbruy
Copy link
Contributor

@alexbruy alexbruy commented May 30, 2023

Show layer atribution information (if present) in the layer details panel
image

@saberraz
Copy link
Contributor

Nice, what do you think of having it under Layer info, instead of adding a new item to an already crowded lower panel?

image

@PeterPetrik
Copy link
Contributor

@alexbruy can you please redo the GUI as suggested by @saberraz . Thanks!

@alexbruy alexbruy changed the title Layer attribution panel Show layer attribution Jun 6, 2023
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating the visual.
Can you please add a simple test for the utils function?
You can add attribution to the test "planes" project and check it in the test, thanks!

app/qml/layers/LayerDetail.qml Show resolved Hide resolved
}

Text {
id: attributionText
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we wrap the attribution into a gray rectangle like with the visibility and legend?

@tomasMizera tomasMizera self-requested a review June 16, 2023 13:06
@PeterPetrik PeterPetrik self-requested a review June 21, 2023 07:17
@tomasMizera tomasMizera merged commit b583afc into dev-2.3 Jul 24, 2023
8 of 9 checks passed
@tomasMizera tomasMizera deleted the layer-attribution branch July 24, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants