fix crash ios gallery #2810
Merged
fix crash ios gallery #2810
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iiLubos
approved these changes
Oct 3, 2023
| @@ -210,7 +210,12 @@ +( void )showImagePicker:( int )sourceType : ( IOSImagePicker * )handler | |||
| // Confirm event | |||
| delegate->imagePickerControllerDidFinishPickingMediaWithInfo = ^( UIImagePickerController * picker, NSDictionary * info ) | |||
| { | |||
| Q_UNUSED( picker ) | |||
There was a problem hiding this comment.
Why did you remove this row?
There was a problem hiding this comment.
it is used on line 223, so it is not unused
| Q_UNUSED( picker ) | ||
| if ( delegate->processingPicture ) | ||
| { | ||
| qWarning() << "Image Picker: Already processing other photo (imagePickerControllerDidFinishPickingMediaWithInfo)"; |
There was a problem hiding this comment.
Better to use CoreUtils::log, no?
There was a problem hiding this comment.
This is not an error that user or support would need to be notified about - if user selects 2 images in quick succession, only one is taken and other one is discarded .
PeterPetrik
added
the
ready-for-testing
|
Verified on 2.4.0 RC (iOS: 2.4.0 (23.10.471911)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1540
fix CU-862keccax
it looks like if the user is really quick he can select another photo in the gallery when the first one is being processed in
imagePickerControllerDidFinishPickingMediaWithInfoand unfortunately I do not see a way to hide that dialog fast enough. The view delegate is not reused between 2 select/capture actions so I addedBOOLto block the second (another) selection while the first one is being proceeded.