[Qt66] qr code from QML + zxing #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
changed the title
PeterPetrik
added
the
ready-for-testing
PeterPetrik
commented
Nov 16, 2023
| { | ||
| auto status = qApp->checkPermission( QCameraPermission{} ); | ||
|
|
||
| if ( Qt::PermissionStatus::Undetermined == status ) |
There was a problem hiding this comment.
This will be handled by @tomasMizera in follow up PR properly (along with location permissions)
wonder-sk
approved these changes
Nov 16, 2023
|
QR code reader is fully working on Android and iOS |
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove workaround introduced in https://github.com/MerginMaps/mobile/pull/2380/files#diff-7c7c5aa42261561514066a886da0dea82b786582bb258a153349042951e8b889 because of bugs in QT framework related to QML Camera on Android/iOS
fix #2669
fix #2604