Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo attachment #3028

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Photo attachment #3028

merged 5 commits into from
Jan 31, 2024

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Jan 24, 2024

image
        MMPhotoEditor {
          title: "MMPhotoEditor"
          width: parent.width
          photoUrl: "https://images.pexels.com/photos/615348/forest-fog-sunny-nature-615348.jpeg"

          onTrashClicked: console.log("Move to trash")
          onContentClicked: console.log("Open photo")
        }

Copy link

Pull Request Test Coverage Report for Build 7639603489

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 60.634%

Totals Coverage Status
Change from base Build 7637321584: 0.02%
Covered Lines: 7538
Relevant Lines: 12432

💛 - Coveralls

app/icons/AddImage.svg Outdated Show resolved Hide resolved
@PeterPetrik
Copy link
Contributor

@iiLubos needs to be rebased

app/qml/components/MMIcon.qml Show resolved Hide resolved
app/qml/components/MMPhoto.qml Show resolved Hide resolved
app/qml/inputs/MMPhotoEditor.qml Show resolved Hide resolved
@tomasMizera tomasMizera merged commit 33cacbe into master Jan 31, 2024
11 checks passed
@tomasMizera tomasMizera deleted the master_addImage branch January 31, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants