Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Home Page #3087

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Project Home Page #3087

merged 2 commits into from
Mar 1, 2024

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Feb 29, 2024 •
edited by PeterPetrik

  • create new project as footer for home page only
  • active project as header for home page only
homepage.mov

@coveralls
Copy link

coveralls commented Feb 29, 2024 •
edited by github-actions bot

Pull Request Test Coverage Report for Build 8108871072

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 60.092%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 6 78.7%
input/app/projectsmodel.cpp 8 66.67%
Totals Coverage Status
Change from base Build 8102139004: -0.04%
Covered Lines: 7547
Relevant Lines: 12559
💛 - Coveralls

PeterPetrik
PeterPetrik reviewed Feb 29, 2024
View reviewed changes
app/qml/components/MMWarningBubble.qml Show resolved Hide resolved
app/qml/project/MMProjectHomePage.qml Outdated Show resolved Hide resolved
app/qml/project/MMProjectHomePage.qml Outdated Show resolved Hide resolved
app/qml/project/MMProjectHomePage.qml Outdated Show resolved Hide resolved
app/qml/project/MMProjectHomePage.qml Outdated Show resolved Hide resolved
@iiLubos iiLubos marked this pull request as ready for review February 29, 2024 16:46
@PeterPetrik PeterPetrik merged commit 7ebe09e into master Mar 1, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the master_projectHomePage branch March 1, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterPetrik PeterPetrik PeterPetrik left review comments

@tomasMizera tomasMizera Awaiting requested review from tomasMizera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iiLubos @coveralls @PeterPetrik @inputapp-bot