Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recording toolbar and errors #3151

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix recording toolbar and errors #3151

merged 2 commits into from
Mar 18, 2024

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Mar 18, 2024 •
edited
Loading

MMLongButton in toolbar was not visible because it was filtered out in the MMToolbar::setupBottomBar function

@tomasMizera tomasMizera merged commit e9d1b49 into master Mar 18, 2024
11 checks passed
@tomasMizera tomasMizera deleted the fix-map-toolbar branch March 18, 2024 07:38
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 8322766811

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 60.211%
Files with Coverage Reduction New Missed Lines %
input/app/projectsmodel.cpp 1 65.75%
input/core/merginapi.cpp 6 78.6%
Totals Coverage Status
Change from base Build 8322604172: -0.06%
Covered Lines: 7583
Relevant Lines: 12594
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterPetrik PeterPetrik Awaiting requested review from PeterPetrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tomasMizera