Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add MMListDrawer and MMListMultiselectDrawer #3169

Merged
merged 12 commits into from
Mar 25, 2024
Merged

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Mar 22, 2024

Todo:

  • handle invisible state
  • add lists to the gallery
  • fix bottom margin with multiselect button

Examples:

  • Use with ListModel or any kind of cpp model
image
  • Use with ObjectModel
image

Copy link

github-actions bot commented Mar 22, 2024

Pull Request Test Coverage Report for Build 8412159451

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 60.105%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 74.45%
Totals Coverage Status
Change from base Build 8386792289: 0.02%
Covered Lines: 7560
Relevant Lines: 12578

💛 - Coveralls

@tomasMizera tomasMizera marked this pull request as ready for review March 22, 2024 15:19
@tomasMizera tomasMizera changed the title Add simple list drawer Add MMListDrawer and MMListMultiselectDrawer Mar 22, 2024
@tomasMizera tomasMizera changed the title Add MMListDrawer and MMListMultiselectDrawer WIP: Add MMListDrawer and MMListMultiselectDrawer Mar 22, 2024
@PeterPetrik
Copy link
Contributor

@tomasMizera I worked a bit on the replacement of drawers in the app - it works really nicely

only issue I had with MMMapController > activeLayerPanel, where I had to set height to delegate otherwise the panel was empty (minimised)

@PeterPetrik PeterPetrik merged commit b7169d3 into master Mar 25, 2024
10 of 11 checks passed
@PeterPetrik PeterPetrik deleted the fix-list-drawers branch March 25, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants