always try to show 4 buttons in toolbar #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8447778046Details
💛 - Coveralls |
tomasMizera
reviewed
Mar 27, 2024
Comment on lines
+151
to
+157
| if (maxButtonsInToolbar < internal.minimumToolbarButtonsInMainToolbar) { | ||
| maxButtonsInToolbar = Math.floor( toolbar.width / internal.minimumToolbarButtonWidth ) | ||
| if (maxButtonsInToolbar > internal.minimumToolbarButtonsInMainToolbar) { | ||
| // we do not want to show more buttons than minimum even they would fit | ||
| maxButtonsInToolbar = internal.minimumToolbarButtonsInMainToolbar | ||
| } | ||
| } |
There was a problem hiding this comment.
I was thinking about something like this - would that work? 🤔
Suggested change
| if (maxButtonsInToolbar < internal.minimumToolbarButtonsInMainToolbar) { | |
| maxButtonsInToolbar = Math.floor( toolbar.width / internal.minimumToolbarButtonWidth ) | |
| if (maxButtonsInToolbar > internal.minimumToolbarButtonsInMainToolbar) { | |
| // we do not want to show more buttons than minimum even they would fit | |
| maxButtonsInToolbar = internal.minimumToolbarButtonsInMainToolbar | |
| } | |
| } | |
| let maxButtonsInToolbar = Math.floor( toolbar.width / internal.preferredToolbarButtonWidth ) | |
| if ( Screen.primaryOrientation === Qt.PortraitOrientation || Qt.InvertedPortraitOrientation ) { | |
| maxButtonsInToolbar = Math.max( maxButtonsInToolbar, internal.minimumToolbarButtonsInMainToolbar) | |
| } |
There was a problem hiding this comment.
this would work on mobiles , but when you will play with width on desktop it will be screwed... and we have windows production version at minimum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if screen size is >= 240px 4 buttons will be shown now (I hope there are no smaller mobile phones :) )
toolbarbuttons.mov